Correctly install script on Windows #17

Merged
merged 1 commit into from Apr 17, 2013

Conversation

Projects
None yet
2 participants

Lukasa commented Apr 17, 2013

For #15.

So the real issue here is that the script file in Windows installs without an extension, and the shebang doesn't work on Windows. This script uses some crazy magic in distribute to basically automatically generate a batch file, which will go in the script directory, and allow installing.

I have to apologise for the diff: the new bits are lines 14-67 of the new version, and line 99 of the new version.

The alternative method, by the way, is to let setuptools build the script entirely. This would remove the binary file. The downside is that you would need to move the function that starts the script into the library itself. If you want to go that route, I can build an alternate PR that does the same thing.

sigmavirus24 added a commit that referenced this pull request Apr 17, 2013

Merge pull request #17 from Lukasa/windows
Correctly install script on Windows

@sigmavirus24 sigmavirus24 merged commit c9df6d1 into sv24-archive:develop Apr 17, 2013

1 check passed

default The Travis build passed
Details
Owner

sigmavirus24 commented Apr 17, 2013

Looks like 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment