Conditionally create default_site web_app #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce the web_app definition can't take an only_if guard, wrapped with an if statement. Specs now reflect the intended behaviour.
svanzoest
added a commit
that referenced
this pull request
Mar 18, 2015
…web_app Conditionally create default_site web_app to avoid creation of the configuration file in `sites-available`.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed another minor issue with the default site, this time with default_site_enabled set to false 😄. The default_site web_app definition is enabled conditionally but is unconditionally created. With default_site_enabled set to false, currently the default site will be deleted from sites-available but subsequently created by the web_app definition again.
Wrapped the web_app definition with an if statement since it can't take an only_if guard and amended the specs to better reflect the default.rb recipe.