Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing EXR and support HDR (RGBE) #2

Merged
merged 1 commit into from May 7, 2019

Conversation

@iwatakeshi
Copy link
Contributor

iwatakeshi commented May 6, 2019

The Exr format is defined in the Type enum but was not implemented. This adds that missing implementation. It also adds support for .hdr files (RGBE).

Note that a few online image converters such as online-convert uses a different file signature for .hdr files than the one defined by Wikipedia. This PR covers both cases.

@svartalf
Copy link
Owner

svartalf commented May 7, 2019

Yeah, you are right, somehow I forgot to add the .exr implementation back in the days.

By any chance you are going to do some more work with this library? I'm more than welcoming this, but it would be very exhaustive to me to publish a new cargo version after each merge :)
If you are going to implement some more stuff, I was thinking about accumulating all the changes and publishing as one version.

@svartalf svartalf merged commit 31a0e92 into svartalf:master May 7, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
iwatakeshi added a commit to iwatakeshi/rust-imghdr that referenced this pull request May 7, 2019
Add missing EXR and support HDR (RGBE) (svartalf#2)
@iwatakeshi
Copy link
Contributor Author

iwatakeshi commented May 7, 2019

@svartalf This should be the last change... 😅. I just ran some tests and all passed so we're good now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.