Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polling mode to support watching shared folders (for Vagrant, Docker, etc.) #22

Closed
Deimos opened this issue Jan 19, 2017 · 4 comments

Comments

@Deimos
Copy link

Deimos commented Jan 19, 2017

Hi @sveetch,

I'm using Boussole inside a Vagrant VM, where my SCSS files are being edited on the host, but are available to the guest through a shared folder. The watch mode doesn't work in this kind of setup, since inotify events don't occur in a shared folder, so watchdog doesn't notice any changes. It looks like some other projects have addressed this by adding an option to use a watchdog PollingObserver instead. If Boussole could add a similar option, that would be very useful for similar development setups.

Here's a couple of links to related issues/PRs for more information:

@sveetch
Copy link
Owner

sveetch commented Jan 19, 2017

So basically, solution would be to add something like a --poll option to use the PollingObserver instead of the default one ?

This should be easy, but sadly i can't test this for now since i dont have any Vagrant/Docker environment, if you are available to do so i can do it in a dedicated branch so you test it then report if it do the trick, ok ?

@Deimos
Copy link
Author

Deimos commented Jan 19, 2017

So basically, solution would be to add something like a --poll option to use the PollingObserver instead of the default one ?

Yes, exactly. I think either a --poll option or a new config-file setting would work well.

if you are available to do so i can do it in a dedicated branch so you test it then report if it do the trick, ok ?

Sure, I'd be happy to test it.

@sveetch sveetch self-assigned this Jan 19, 2017
@sveetch
Copy link
Owner

sveetch commented Jan 21, 2017

It's ok, the "poll" option is available with the 1.2.0 version (commit 381b02c).

@Deimos
Copy link
Author

Deimos commented Jan 22, 2017

Tested and it works perfectly, thanks very much for implementing that so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants