Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovering and default settings backend filename #30

Closed
sveetch opened this issue Jun 4, 2018 · 3 comments
Closed

Discovering and default settings backend filename #30

sveetch opened this issue Jun 4, 2018 · 3 comments

Comments

@sveetch
Copy link
Owner

sveetch commented Jun 4, 2018

Default filename for settings is currently settings.json, it is not enough since other software use a settings.* file, this may trouble user.

It would be nice that boussole search first for a boussole.json file then settings.json that will continue to be supported for ever.

@tehfink
Copy link

tehfink commented Sep 14, 2018

It would also be nice if boussole could automatically determine the backend from the boussole.xxx configuration file's format. This doesn't work as expected:

$ boussole startproject --backend yaml
Project base directory [.]: 
Sources directory [scss]: sass
Target directory [css]: compiled
15:29:58 - Project directory structure and configuration file have been created.
15:29:58 - Now you should start to create some Sass sources into '/Users/tehfink/…/my_project/static/css/sass', then compile them using:
15:29:58 -     boussole compile --config=/Users/tehfink/…/my_project/static/css/settings.yml
$ boussole -v 5 compile
15:30:09 - Building project
15:30:09 - Unable to find settings file: /Users/tehfink/…/my_project/static/css/settings.json
Aborted!
$ boussole -v 5 compile --config=settings.yml 
15:30:26 - Building project
15:30:26 - No JSON object could be decoded from file: /Users/tehfink/…/my_project/static/css/settings.yml
Aborted!

@sveetch
Copy link
Owner Author

sveetch commented Sep 14, 2018

@tehfink sure it would be, i didn't do it because i felt automatic guess would bring some "magic", but think it again, i may have changed my mind.

I will definitively think about it again when i will have some time for this issue.

@sveetch sveetch changed the title boussole.json Discovering and default settings backend filename Sep 29, 2018
sveetch added a commit that referenced this issue Sep 29, 2018
Introduce a new way to load settings file with a magical discovering
which either just load given an explicit file path or try to find
it from base directory and available settings backends. This is
related to issue #30.

This should not include backward incompatible behavior, it just adds
capacity to find another backend default filename kind.

Concretely, before this release only 'settings.json' would be finded
when no explicit file path was given and now it will be able to find
also a file 'settings.yml' if it exists in current directory.
sveetch added a commit that referenced this issue Sep 30, 2018
Introduce a new way to load settings file with a magical discovering
which either just load given an explicit file path or try to find
it from base directory and available settings backends. This is
related to issue #30.

This should not include backward incompatible behavior, it just adds
capacity to find another backend default filename kind.

Concretely, before this release only 'settings.json' would be finded
when no explicit file path was given and now it will be able to find
also a file 'settings.yml' if it exists in current directory.
sveetch added a commit that referenced this issue Sep 30, 2018
Introduce a new way to load settings file with a magical discovering
which either just load given an explicit file path or try to find
it from base directory and available settings backends. This is
related to issue #30.

This should not include backward incompatible behavior, it just adds
capacity to find another backend default filename kind.

Concretely, before this release only 'settings.json' would be finded
when no explicit file path was given and now it will be able to find
also a file 'settings.yml' if it exists in current directory.
sveetch added a commit that referenced this issue Sep 30, 2018
Introduce a new way to load settings file with a discovering
which either just load given an explicit file path or try to find
it from base directory and available settings backends. This is
related to issue #30.

This should not include backward incompatible behavior, it just adds
capacity to find another backend default filename kind.

Concretely, before this release only 'settings.json' would be finded
when no explicit file path was given and now it will be able to find
also a file 'settings.yml' if it exists in current directory.
@sveetch
Copy link
Owner Author

sveetch commented Feb 7, 2021

Should be totally implemented as from 2.0.0 release

@sveetch sveetch closed this as completed Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants