need to look at tests again in demo

Author: jycouet

packages/sv/lib/cli/tests/cli.ts

@@ -41,16 +41,15 @@ describe('cli', () => {
 		{
 			projectName: 'create-addon',
 			template: 'addon',
-			types: 'jsdoc',
 			args: ['--no-add-ons']
 		}
 	];
 
 	it.for(testCases)(
 		'should create a new project with name $projectName',
-		{ timeout: 10_000 },
+		{ timeout: 20_000 },
 		async (testCase) => {
-			const { projectName, args, template = 'minimal', types = 'ts' } = testCase;
+			const { projectName, args, template = 'minimal' } = testCase;
 			const testOutputPath = path.resolve(monoRepoPath, '.test-output', 'cli', projectName);
 
 			const result = await exec(
@@ -61,16 +60,15 @@ describe('cli', () => {
 					testOutputPath,
 					'--template',
 					template,
-					'--types',
-					types,
+					...(template === 'addon' ? ['--no-types'] : ['--types', 'ts']),
 					'--no-install',
 					...args
 				],
 				{ nodeOptions: { stdio: 'pipe' } }
 			);
 
 			// cli finished well
-			expect(result.exitCode).toBe(0);
+			expect(result.exitCode, `Error with cli: '${result.stderr}'`).toBe(0);
 
 			// test output path exists
 			expect(fs.existsSync(testOutputPath)).toBe(true);
@@ -114,11 +112,11 @@ describe('cli', () => {
 
 			if (template === 'addon') {
 				const cmds = [
+					// list of cmds to test
 					['i'],
 					['run', 'demo-create'],
 					['run', 'demo-add'],
-					// TODO JYC: check is failing because it's requesting kit! :o
-					['run', 'check']
+					['run', 'test']
 				];
 				for (const cmd of cmds) {
 					const res = await exec('npm', cmd, {

packages/sv/lib/cli/tests/snapshots/create-addon/jsconfig.json

@@ -1,19 +1,10 @@
 {
-	"extends": "./.svelte-kit/tsconfig.json",
+	"exclude": ["**/temp/**"],
 	"compilerOptions": {
-		"allowJs": true,
-		"checkJs": true,
-		"esModuleInterop": true,
-		"forceConsistentCasingInFileNames": true,
-		"resolveJsonModule": true,
-		"skipLibCheck": true,
-		"sourceMap": true,
 		"strict": true,
-		"moduleResolution": "bundler"
+		"skipLibCheck": true,
+		"checkJs": true,
+		"module": "Node16",
+		"moduleResolution": "Node16"
 	}
-	// Path aliases are handled by https://svelte.dev/docs/kit/configuration#alias
-	// except $lib which is handled by https://svelte.dev/docs/kit/configuration#files
-	//
-	// If you want to overwrite includes/excludes, make sure to copy over the relevant includes/excludes
-	// from the referenced tsconfig.json - TypeScript does not merge them in
 }

packages/sv/lib/cli/tests/snapshots/create-addon/package.json

@@ -6,9 +6,7 @@
 	"scripts": {
 		"demo-create": "sv create demo --types ts --template minimal --no-add-ons --no-install",
 		"demo-add": "sv add -C demo --community file:../ --no-git-check --no-install",
-		"test": "vitest run",
-		"check": "svelte-kit sync && svelte-check --tsconfig ./jsconfig.json",
-		"check:watch": "svelte-kit sync && svelte-check --tsconfig ./jsconfig.json --watch"
+		"test": "vitest run"
 	},
 	"files": [
 		"src",
@@ -20,8 +18,6 @@
 	},
 	"devDependencies": {
 		"@playwright/test": "^1.56.1",
-		"svelte-check": "^4.3.4",
-		"typescript": "^5.9.3",
 		"vitest": "4.0.7"
 	},
 	"keywords": [

packages/sv/lib/cli/tests/snapshots/create-addon/vitest.config.js

@@ -8,7 +8,7 @@ export default defineConfig({
 		exclude: ['tests/setup/*'],
 		testTimeout: ONE_MINUTE * 3,
 		hookTimeout: ONE_MINUTE * 3,
-		globalSetup: ['tests/setup/global.ts'],
+		globalSetup: ['tests/setup/global.js'],
 		expect: {
 			requireAssertions: true
 		}

packages/sv/lib/create/templates/addon/vitest.config.js

@@ -8,7 +8,7 @@ export default defineConfig({
 		exclude: ['tests/setup/*'],
 		testTimeout: ONE_MINUTE * 3,
 		hookTimeout: ONE_MINUTE * 3,
-		globalSetup: ['tests/setup/global.ts'],
+		globalSetup: ['tests/setup/global.js'],
 		expect: {
 			requireAssertions: true
 		}