feat: support kit's explicit environment variables#1122
Merged
Conversation
…rom cwd
Drop dependencyVersion/language from the context (read kit version and ts/js
from cwd) to match svelteConfig's { sv, cwd } shape. Rename declare -> define.
Mode stays internal; add-ons never thread it.
Mirrors the workspace's resolution so a monorepo project that declares kit only in a parent package.json is still detected (closest wins).
…ng it
Add-ons pass dependencyVersion('@sveltejs/kit') (the engine's authoritative,
walk-up-aware resolution). Removes findKitRange's package.json walk-up from
sv-utils - dependency resolution belongs to the engine, not sv-utils. The
experimental flag is still read from the config here, where config-reading
already lives.
Call site is just { sv, cwd, dependencyVersion } - the workspace's authoritative
walk-up lookup, called internally for @sveltejs/kit. Cleaner than threading a
pre-resolved kitVersion value.
🦋 Changeset detectedLatest commit: b67ab07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
drizzleandbetter-authnow emit kit's explicit environment variables (src/env.ts+$app/env/private) when the project uses them in kit 3 /next, or kit 2 withexplicitEnvironmentVariables. And fall back to legacy$env/dynamic/privateotherwise.defineEnvhelper tosv-utils.The new util will be reuse for a future
sv migrate env!Checklist