implicitly allow Response object instance (#3697)

* conditionally check Output as Response * add changset * docs
sveltejs · Feb 3, 2022 · ccc780b · ccc780b
1 parent 6e86c4a
commit ccc780b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/few-rockets-sort.md b/.changeset/few-rockets-sort.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+Allow Response object to be returned without properties showing up in object constructor
diff --git a/documentation/docs/01-routing.md b/documentation/docs/01-routing.md
@@ -72,7 +72,9 @@ interface Fallthrough {
 }
 
 export interface RequestHandler<Output extends Body = Body> {
-	(event: RequestEvent): MaybePromise<Either<Response | EndpointOutput<Output>, Fallthrough>>;
+	(event: RequestEvent): MaybePromise<
+		Either<Output extends Response ? Response : EndpointOutput<Output>, Fallthrough>
+	>;
 }
 ```
 

diff --git a/packages/kit/types/endpoint.d.ts b/packages/kit/types/endpoint.d.ts
@@ -14,5 +14,7 @@ export interface Fallthrough {
 }
 
 export interface RequestHandler<Output extends Body = Body> {
-	(event: RequestEvent): MaybePromise<Either<Response | EndpointOutput<Output>, Fallthrough>>;
+	(event: RequestEvent): MaybePromise<
+		Either<Output extends Response ? Response : EndpointOutput<Output>, Fallthrough>
+	>;
 }