From eaa8a053592449dd5aa7f68dff4c4778557a28ab Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Mon, 18 Apr 2022 08:36:52 -0700 Subject: [PATCH] [chore] rename data-svelte to data-sveltekit (#4641) * [chore] rename data-svelte to data-sveltekit * Create tiny-hounds-glow.md Co-authored-by: Rich Harris --- .changeset/tiny-hounds-glow.md | 5 +++++ packages/kit/src/runtime/client/client.js | 2 +- packages/kit/src/runtime/server/page/render.js | 2 +- packages/kit/test/apps/basics/test/test.js | 2 +- packages/kit/test/apps/options/test/test.js | 4 ++-- 5 files changed, 10 insertions(+), 5 deletions(-) create mode 100644 .changeset/tiny-hounds-glow.md diff --git a/.changeset/tiny-hounds-glow.md b/.changeset/tiny-hounds-glow.md new file mode 100644 index 000000000000..2092fdb38da0 --- /dev/null +++ b/.changeset/tiny-hounds-glow.md @@ -0,0 +1,5 @@ +--- +"@sveltejs/kit": patch +--- + +rename `data-svelte` attribute to `data-sveltekit` diff --git a/packages/kit/src/runtime/client/client.js b/packages/kit/src/runtime/client/client.js index 287295d0d601..8acbb09e9cdf 100644 --- a/packages/kit/src/runtime/client/client.js +++ b/packages/kit/src/runtime/client/client.js @@ -341,7 +341,7 @@ export function create_client({ target, session, base, trailing_slash }) { function initialize(result) { current = result.state; - const style = document.querySelector('style[data-svelte]'); + const style = document.querySelector('style[data-sveltekit]'); if (style) style.remove(); page = result.props.page; diff --git a/packages/kit/src/runtime/server/page/render.js b/packages/kit/src/runtime/server/page/render.js index a9d8fa509e54..a389ea2c365a 100644 --- a/packages/kit/src/runtime/server/page/render.js +++ b/packages/kit/src/runtime/server/page/render.js @@ -206,7 +206,7 @@ export async function render_response({ } else { if (inlined_style) { const attributes = []; - if (options.dev) attributes.push(' data-svelte'); + if (options.dev) attributes.push(' data-sveltekit'); if (csp.style_needs_nonce) attributes.push(` nonce="${csp.nonce}"`); csp.add_style(inlined_style); diff --git a/packages/kit/test/apps/basics/test/test.js b/packages/kit/test/apps/basics/test/test.js index 9766729ba0e6..c2cf2424d8a0 100644 --- a/packages/kit/test/apps/basics/test/test.js +++ b/packages/kit/test/apps/basics/test/test.js @@ -1527,7 +1527,7 @@ test.describe.parallel('Page options', () => { expect(await page.textContent('h1')).toBe('content was rendered'); } else { expect(await page.evaluate(() => document.querySelector('h1'))).toBe(null); - expect(await page.evaluate(() => document.querySelector('style[data-svelte]'))).toBe(null); + expect(await page.evaluate(() => document.querySelector('style[data-sveltekit]'))).toBe(null); } }); diff --git a/packages/kit/test/apps/options/test/test.js b/packages/kit/test/apps/options/test/test.js index 767af838cb76..b0d44c7b82c0 100644 --- a/packages/kit/test/apps/options/test/test.js +++ b/packages/kit/test/apps/options/test/test.js @@ -45,10 +45,10 @@ test.describe.parallel('base path', () => { test('inlines CSS', async ({ page, javaScriptEnabled }) => { await page.goto('/path-base/base/'); if (process.env.DEV) { - const ssr_style = await page.evaluate(() => document.querySelector('style[data-svelte]')); + const ssr_style = await page.evaluate(() => document.querySelector('style[data-sveltekit]')); if (javaScriptEnabled) { - //