Skip to content

Conversation

@Conduitry
Copy link
Member

There are a few references to fallthrough routes that survived in the docs.

A couple of the references can be removed in a fairly naive way. One of the FAQ entries was removed because I don't see what it would make sense to replace it with. The reference in the Sapper migration docs about regex routes has been updated to refer to the new route matching feature.

I'm definitely open to more elegant ways of handling some of these changes, if anyone has ideas.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@Conduitry Conduitry added the documentation Improvements or additions to documentation label Mar 18, 2022
@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2022

⚠️ No Changeset found

Latest commit: 2292c36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit 516e88a into sveltejs:master Mar 18, 2022
@Rich-Harris
Copy link
Member

LGTM

@Conduitry Conduitry deleted the remove-fallthrough-docs branch February 27, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants