Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add invalidateAll option to goto #7407

Merged
merged 2 commits into from Oct 28, 2022
Merged

Conversation

dummdidumm
Copy link
Member

Useful after form submissions for example, which will now use it in case of a redirect response

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Useful after form submissions for example, which will now use it in case of a redirect response
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2022

🦋 Changeset detected

Latest commit: 0304d81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@geoffrich
Copy link
Member

Is it possible to document what the invalidateAll option does? (mostly self explanatory, but still good to specify). Though it seems like the goto options aren't currently documented anyway.

@dummdidumm
Copy link
Member Author

Existing params are documented, but in a weird way in the jsdoc. Will adjust and add doc for invalidateAll

@Rich-Harris Rich-Harris merged commit d2dddb3 into master Oct 28, 2022
@Rich-Harris Rich-Harris deleted the goto-invalidate-all branch October 28, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants