Permalink
6 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
(fix) make runtime/ls-path configurable in user settings only
Due to security reasons: If this could be set in the workspace, a malicious workspace could point this to an arbitrary executable.
- Loading branch information
1 parent
42fded0
commit 5d7bf1f
Showing
1 changed file
with
4 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d7bf1fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dummdidumm, what's the recommended approach when one needs to configure
svelte.language-server.ls-pathfor a team working on the same project/workspace?5d7bf1fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everyone needs to configure it themselves, due to security reasons there is no other way
5d7bf1fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks for answering :)
5d7bf1fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again @dummdidumm. Now that there's a workspace trust feature, is it possible to allow this setting to be configurable via workspace settings if workspace trust has been enabled?
5d7bf1fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I think that would make sense. I'll add that to #1051
5d7bf1fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the quick response!