From c8b1950ebda2d12d13cc4d3fc54eaf4c115027ec Mon Sep 17 00:00:00 2001 From: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Wed, 5 Aug 2020 11:39:10 +0200 Subject: [PATCH] (fix) missing-custom-element-compile-options cannot be ignored #409 --- .../svelte/features/getCodeActions/getQuickfixes.ts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/packages/language-server/src/plugins/svelte/features/getCodeActions/getQuickfixes.ts b/packages/language-server/src/plugins/svelte/features/getCodeActions/getQuickfixes.ts index deab8bc93..2c70c80b8 100644 --- a/packages/language-server/src/plugins/svelte/features/getCodeActions/getQuickfixes.ts +++ b/packages/language-server/src/plugins/svelte/features/getCodeActions/getQuickfixes.ts @@ -67,10 +67,20 @@ function getCodeActionTitle(diagnostic: Diagnostic) { return `(svelte) Disable ${diagnostic.code} for this line`; } +/** + * Whether or not the given diagnostic can be ignored via a + * + */ export function isIgnorableSvelteDiagnostic(diagnostic: Diagnostic) { const { source, severity, code } = diagnostic; - return code && source === 'svelte' && severity !== DiagnosticSeverity.Error; + return ( + code && + !nonIgnorableWarnings.includes(code) && + source === 'svelte' && + severity !== DiagnosticSeverity.Error + ); } +const nonIgnorableWarnings = ['missing-custom-element-compile-options']; async function getSvelteIgnoreEdit(svelteDoc: SvelteDocument, ast: Ast, diagnostic: Diagnostic) { const {