-
-
Notifications
You must be signed in to change notification settings - Fork 223
Closed
Labels
FixedFixed in master branch. Pending production release.Fixed in master branch. Pending production release.feature requestNew feature or requestNew feature or request
Description
The new VS Code version introduced "Workspace Trust". If someone doesn't trust a folder/workspace they have opened, VS Code only provides limited interaction with the code base. This includes extensions: They are turned off completely, if they don't implement some of the Workspace Trust APIs. Extension can provide a description of what subset of functionality should be enabled. More on that and a questionnaire which helps determining what to do here: microsoft/vscode#120251
I think what we need to do in Workspace Trust is:
- Disable loading the svelte.config.js, it could contain malicious code. If one is present, we should turn off running the diagnostics of the Svelte compiler as we can't know for sure how to preprocess the files.
- Don't load the user's version of prettier/svelte/svelte-preprocess (
importPackage.ts) and instead use our own version of that - check the built-in typescript extension of VS Code to see if they turn off something, and turn that off, too . Edit: They turn of these settings which don't affect us
- investigate if we can reenable the ls-path and node executable setting to be workspace settings. If the user trusts the workspace, he likely also trusts the workspace settings
kotx and joelmukuthu
Metadata
Metadata
Assignees
Labels
FixedFixed in master branch. Pending production release.Fixed in master branch. Pending production release.feature requestNew feature or requestNew feature or request