bumps typescript to 4.3 and support semantic tokens on js #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
approved these changes
May 27, 2021
Member
dummdidumm
left a comment
dummdidumm
left a comment
There was a problem hiding this comment.
👍
Since TS 4.3 seems to have changed some other things as well, I'm starting to wonder if we should use ~latest minor instead of * for TS inside the language server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typescript allows semantic tokens to run on js in 4.3. Remove the doesn't-applied note.
The import statement completion added in typescript 4.3 is a bit more complex. I'll add the support in another PR.