(feat) slot-let completion/hover for components with a type definition #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 20, 2021 14:30
Uses the TS type checker to retrieve the slot let: type of the component. Enables completions and hover info for components defined in d.ts files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the TS type checker to retrieve the slot let: type of the component. Enables completions and hover info for components defined in d.ts files
@jasonlyu123 I reverted the caching as I fear it may lead to memory leaks when old/stale type checkers are cached; also I didn't notice any performance drops. Sorry about the noise in that other PR requesting you to put in the caching logic.