(breaking) rename ambient __sveltets_-declarations #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 20, 2021 16:22
Rename all __sveltets_* ambient declarations to __sveltets_1_* . This way, we avoid the situation where multiple ambient versions of svelte2tsx are loaded and their declarations conflict each other. sveltejs#1059 for an example bug that stems from it. The other breaking change is that svelte2tsx no longer provides a default export, svelte2tsx now is a named export. This opens up the possibility to export other utility functions alongside it.
This is handled by Prettier already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename all _sveltets* ambient declarations to _sveltets_1* . This way, we avoid the situation where multiple ambient versions of svelte2tsx are loaded and their declarations conflict each other. #1059 for an example bug that stems from it.
The other breaking change is that svelte2tsx no longer provides a default export, svelte2tsx now is a named export. This opens up the possibility to export other utility functions alongside it.
@jasonlyu123 FYI we discussed making these imports, but I dismissed the solution as the import messes with the language server when doing import completions, "organize imports" etc.