Skip to content

Conversation

@takurinton
Copy link

There was 1 error inside the catch block when building svelte-check.
I used a branch by instanceof and avoided it.

npm run build 

... 

src/index.ts:95:24 - error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Error'.

95         writer.failure(err);
                          ~~~

Found 1 error.

@jasonlyu123
Copy link
Member

We haven't updated to typescript 4.4 yet. And this error is probably from typescript 4.4's new useUnknownInCatchVariables flag. There should still be multiple places where this error might happen in the codebase. I think we prefer dealing with it together after the update. It's currently blocked by an upstream issue.

@dummdidumm
Copy link
Member

This is somewhat of a subset of #1158 which will handle this in one go after TS releases it's patch. Therefore closing this as a duplicate. Still thanks for your contribution!

@dummdidumm dummdidumm closed this Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants