Skip to content

(fix) svelte2tsx runtime error diagnostics line number #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2021
Merged

(fix) svelte2tsx runtime error diagnostics line number #1183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6984e5
null check in checkIfImportIsEventDispatcher
jasonlyu123 Sep 27, 2021
b0a428d
fix svelte2tsx runtime error diagnostics
jasonlyu123 Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/language-server/src/plugins/typescript/DocumentSnapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ function preprocessSvelteFile(document: Document, options: SvelteSnapshotOptions
} catch (e: any) {
// Error start/end logic is different and has different offsets for line, so we need to convert that
const start: Position = {
line: e.start?.line - 1 ?? 0,
line: (e.start?.line ?? 1) - 1,
character: e.start?.column ?? 0
};
const end: Position = e.end ? { line: e.end.line - 1, character: e.end.column } : start;
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte2tsx/src/svelte2tsx/nodes/ComponentEvents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ function checkIfImportIsEventDispatcher(node: ts.ImportDeclaration): string | un
}

const namedImports = node.importClause?.namedBindings;
if (ts.isNamedImports(namedImports)) {
if (namedImports && ts.isNamedImports(namedImports)) {
const eventDispatcherImport = namedImports.elements.find(
// If it's an aliased import, propertyName is set
(el) => (el.propertyName || el.name).text === 'createEventDispatcher'
Expand Down