(perf) typescript language service size limit #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
reviewed
Oct 5, 2021
Member
dummdidumm
left a comment
dummdidumm
left a comment
There was a problem hiding this comment.
Very nice! The approach looks good. Left some comments.
| continue; | ||
| } | ||
|
|
||
| totalNonTsFileSize += ts.sys.getFileSize?.(fileName) ?? 0; |
Member
There was a problem hiding this comment.
Out of curiosity: Is this performance heavy to check that? How often is this called? My fear is that if this results in many IO operations, that it slows down the intellisense for people.
Member
Author
There was a problem hiding this comment.
Currently, it only runs on startup and when there're new .ts or .js files added. With the file-count-check, it should not be very often. It's 10-20ms on my SSD with 300-500 project files workspaces, and 20-30ms on a hard drive. So I guess it shouldn't be too noticeable to most people.
dummdidumm
reviewed
Oct 6, 2021
| snapshotManager.updateProjectFiles(); | ||
| const projectFileCountAfter = snapshotManager.getProjectFileNames().length; | ||
|
|
||
| if (projectFileCountAfter <= projectFileCountBefore) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#965
Add a size limit for typescript language service similar to the one in the tsserver. When the size limit exceeds, ts language service goes into a reduced mode. Project-wide IntelliSense is disabled. It would only use the files opened in the client. Kind of like when you don't have a tsconfig.json file. When this happens a warning message will show up.
Noted if you have a really big project and you have excluded everything needed but it still exceeds this limit. You can disable it with the
disableSizeLimitcompiler options in the tsconfig/jsconfig.