(fix) fall back to any type when array is of type any #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a overzealous check introduced through sveltejs#1218
jasonlyu123
approved these changes
Nov 17, 2021
Member
jasonlyu123
left a comment
jasonlyu123
left a comment
There was a problem hiding this comment.
Looks good. Not quite certain how it works but it seems like any is the only one that takes priority over unknown in here.
Member
Author
|
Yeah I'm a little confused myself about this, almost like TS takes the results of the extends clause into account when deciding what to resolve to. Thanks for having a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a overzealous check introduced through #1218