(fix) Adhere to code formatting settings when organizing imports #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 3, 2021 13:39
Add semicolon or not depending on Prettier config sveltejs#1260
Member
Author
|
Ready for review. @jasonlyu123 maybe you have any idea why TS ignores the settings in this case? If not, I would merge this if you think the solution is fine. |
jasonlyu123
reviewed
Dec 6, 2021
packages/language-server/src/plugins/typescript/features/CodeActionsProvider.ts
Show resolved
Hide resolved
Contributor
|
@dummdidumm Thanks for tackling this so quickly! The flashing semicolons are gone. I think the underlying issue remains though. The imports themselves still flash and (more annoyingly) every save adds to the files edit history. If I want to revert a change, I still have to click cmd + z twice. The first cmd + z always undoes the import sorting, even if all imports were already in sorted order. |
Member
Author
|
I created #1269 to track this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add semicolon or not depending on Prettier config
#1260
Doesn't work yet, for some reason TS does not care about us passing the setting in, may need to do a regex replacement.