(fix) no TS/JS completions in html text #1369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sveltejs#1352 This makes use of the Svelte AST that is now returned from svelte2tsx (privately, do not use this elsewhere!) by checking if the AST node at the given position is of type text. This also helped refactor some other checks into something less hacky
Member
|
Seem like a good idea. We probably can't use the AST from vscode-html-languageservice here as most of the svelte block and moustache is treated as text. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1352
This makes use of the Svelte AST that is now returned from svelte2tsx (privately, do not use this elsewhere!) by checking if the AST node at the given position is of type text. This also helped refactor some other checks into something less hacky
@jasonlyu123 what do think of this approach, using the Svelte AST more in the language server?