Skip to content

(fix) $store++/$store-- return type #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2022
Merged

(fix) $store++/$store-- return type #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f34e09f
(fix) $store++/$store-- return type
Feb 20, 2022
1b4778d
v2 test
Feb 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/svelte2tsx/src/svelte2tsx/nodes/Stores.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function handleStore(node: Node, parent: Node, str: MagicString): void {
str.overwrite(
parent.start,
parent.end,
`${storename}.set( $${storename} ${simpleOperator} 1)`
`(${storename}.set( $${storename} ${simpleOperator} 1), $${storename})`
);
} else {
console.warn(
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte2tsx/src/svelte2tsx/processInstanceScriptContent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export function processInstanceScriptContent(
str.overwrite(
parent.getStart() + astOffset,
parent.end + astOffset,
`${storename}.set( $${storename} ${simpleOperator} 1)`
`(${storename}.set( $${storename} ${simpleOperator} 1), $${storename})`
);
return;
} else {
Expand Down
10 changes: 5 additions & 5 deletions packages/svelte2tsx/test/svelte2tsx/samples/uses-$store-with-increments/expected.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ function render() {


const count = writable(0)/*Ωignore_startΩ*/;let $count = __sveltets_1_store_get(count);/*Ωignore_endΩ*/;
const handler1 = () => count.set( $count + 1)
const handler2 = () => count.set( $count - 1)
const handler1 = () => (count.set( $count + 1), $count)
const handler2 = () => (count.set( $count - 1), $count)
;
() => (<>

<button onclick={() => count.set( $count + 1)}>add</button>
<button onclick={() => count.set( $count - 1)}>subtract</button>
<button onclick={() => count.set( $count + 1)}>add</button></>);
<button onclick={() => (count.set( $count + 1), $count)}>add</button>
<button onclick={() => (count.set( $count - 1), $count)}>subtract</button>
<button onclick={() => (count.set( $count + 1), $count)}>add</button></>);
return { props: {}, slots: {}, getters: {}, events: {} }}

export default class Input__SvelteComponent_ extends __sveltets_1_createSvelte2TsxComponent(__sveltets_1_partial(__sveltets_1_with_any_event(render()))) {
Expand Down
10 changes: 5 additions & 5 deletions packages/svelte2tsx/test/svelte2tsx/samples/uses-$store-with-increments/expectedv2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ function render() {


const count = writable(0)/*Ωignore_startΩ*/;let $count = __sveltets_1_store_get(count);/*Ωignore_endΩ*/;
const handler1 = () => count.set( $count + 1)
const handler2 = () => count.set( $count - 1)
const handler1 = () => (count.set( $count + 1), $count)
const handler2 = () => (count.set( $count - 1), $count)
;
async () => {

{ svelteHTML.createElement("button", { "onclick":() => count.set( $count + 1),}); }
{ svelteHTML.createElement("button", { "onclick":() => count.set( $count - 1),}); }
{ svelteHTML.createElement("button", { "onclick":() => count.set( $count + 1),}); }};
{ svelteHTML.createElement("button", { "onclick":() => (count.set( $count + 1), $count),}); }
{ svelteHTML.createElement("button", { "onclick":() => (count.set( $count - 1), $count),}); }
{ svelteHTML.createElement("button", { "onclick":() => (count.set( $count + 1), $count),}); }};
return { props: {}, slots: {}, getters: {}, events: {} }}

export default class Input__SvelteComponent_ extends __sveltets_1_createSvelte2TsxComponent(__sveltets_1_partial(__sveltets_1_with_any_event(render()))) {
Expand Down