Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Svelte Atom #160

Closed
wants to merge 4 commits into from
Closed

Integrate Svelte Atom #160

wants to merge 4 commits into from

Conversation

orta
Copy link
Contributor

@orta orta commented Jun 4, 2020

Once I read the code, I realized that this really is a simple LSP wrapper, and there's not much code here.

TODO:

  • deploys

@orta
Copy link
Contributor Author

orta commented Jun 4, 2020

deployment is tricky, because it relates to the repo and having GitHub org access

@orta
Copy link
Contributor Author

orta commented Jun 12, 2020

@orta
Copy link
Contributor Author

orta commented Jun 26, 2020

I think with the production deploys PR in this is less unblocked in my mind, I'd want this to only make deploys when there are prod deploys of the extension

@dummdidumm
Copy link
Member

dummdidumm commented Jun 28, 2020

FYI I had to do some fixes in #239 to get lint/test running again. This will likely cause some merge conflicts for this PR.

@orta
Copy link
Contributor Author

orta commented Jun 28, 2020

Ah, hrm, that shouldn't be there - must have been an accidental push somewhere

@orta orta mentioned this pull request Jun 29, 2020
@orta
Copy link
Contributor Author

orta commented Jul 21, 2020

When I looked at this again, I think I was blocked on the fact that we have a monorepo and GH makes some assumptions about your repo in the atom deployment process, I'll need to look again

@the0neWhoKnocks
Copy link

the0neWhoKnocks commented Aug 3, 2020

Looks like it's been almost 2 weeks since the last activity on this PR. As an Atom user, just curious if this is getting abandoned.

@orta
Copy link
Contributor Author

orta commented Aug 3, 2020

It's just work I've not prioritized, that's all

@orta
Copy link
Contributor Author

orta commented Aug 31, 2020

An update, as I gave it another shot over the weekend.

There's some assumptions with how GitHub treats atom extensions which requires having everything set at the root of the git directory even with scripting the files to be at the fs root then. I think we can skip the generation of tags and releases which are just for the extension but having the fs at the root is a pretty big blocker.

I'm going to move this PR to draft, it's blocked on monorepo support inside the atom publishing CLI apm.

I'm not really game for diving into a big coffeescript codebase to try and add monorepo support, so if this extension is something you want to see happen - now is a good chance to start contributing.

@orta orta marked this pull request as draft Aug 31, 2020
@dummdidumm
Copy link
Member

dummdidumm commented Sep 7, 2020

You are also welcome to copy the setup code (main.js, package.json, readme.md) and open a separate repo and deploy the extension yourself to work around the monorepo limitation.

@dummdidumm
Copy link
Member

dummdidumm commented Sep 7, 2020

Just noticed, there is also this official repo https://github.com/sveltejs/svelte-atom which we could use. @orta what do you think? If you think it's okay to have it in a separate repo for deployment reasons, mind taking another stab at this in that repo?

@dummdidumm
Copy link
Member

dummdidumm commented Dec 17, 2021

Closing in favor of sveltejs/svelte-atom#10

@dummdidumm dummdidumm closed this Dec 17, 2021
@dummdidumm dummdidumm deleted the svelte-atom branch Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants