Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte-check: Add --preserveWatchOutput, which disables clearing the terminal when using --watch #1715

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

odinhb
Copy link
Contributor

@odinhb odinhb commented Nov 7, 2022

Context:
I am trying to add svelte to our application, which has previously been using tsc to typecheck our codebase, (and esbuild to build).

tsc and svelte-check were both annoying when run from a process manager, such as overmind, which runs multiple cli tools/watchers etc in the same terminal. This is because they by default clear the screen periodically, which blows away useful information from other tools.

tsc supports --preserveWatchOutput, (link) so I added the same flag to svelte-check.

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm
Copy link
Member

Could you run yarn format at the root of the monorepo and push the formatting changes so CI is green?

Context:
I am trying to add svelte to our application, which has previously been
using tsc to typecheck our codebase, (and esbuild to build).

tsc and svelte-check were both annoying when run from a process manager,
such as overmind, which runs multiple cli tools/watchers etc in the same
terminal. This is because they by default clear the screen periodically,
which blows away useful information from other tools.

tsc supports --preserveWatchOutput, so I added the same flag to
svelte-check.
@dummdidumm dummdidumm merged commit 6bd57b0 into sveltejs:master Nov 14, 2022
@odinhb
Copy link
Contributor Author

odinhb commented Nov 25, 2022

@dummdidumm Is it too much to ask for a minor version release for this? I'd like to stop using my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants