(fix) if conditions control flow #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an IfScope to svelte2tsx which keeps track of the if scope including nested ifs. That scope is used to prepend the resulting condition check to all inner lambda functions that svelte2tsx needs to create for slot, each, await. This way, TypeScript's control flow can determine the type of checked variables and no longer loses that info due to the lambda functions. sveltejs#619
added 15 commits
March 1, 2021 19:22
add SnapshotFragmentMap util
Member
Author
|
@jasonlyu123 could you review this? The logic is a little complicated and I changed code in quite a few places (although most of the new code is tests) and I want to make sure I'm not doing something stupid here or if the approach I took here is not good in your opinion. High level summary: The if-conditions are repeated and prepended to the lambda functions to reinstantiate control flow. I introduced comments around them to be able to filter those repeats out when returning things like diagnostics,rename etc. That comment could possibly used in other places, too, later on. |
jasonlyu123
reviewed
Mar 8, 2021
Member
jasonlyu123
left a comment
jasonlyu123
left a comment
There was a problem hiding this comment.
Overall great. Didn't found many problems. Just some minor one
added 2 commits
March 8, 2021 15:50
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an IfScope to svelte2tsx which keeps track of the if scope including nested ifs. That scope is used to prepend the resulting condition check to all inner lambda functions that svelte2tsx needs to create for slot, each, await. This way, TypeScript's control flow can determine the type of checked variables and no longer loses that info due to the lambda functions.
#619
TODO:
handle shadowed variablesremove hidden checks from getDefinitions/findReferences/diagnosticsfix rename