Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Change scrollX & scrollY to pageXOffset & pageYOffset? #480

Closed
johanalkstal opened this issue Oct 18, 2018 · 1 comment · Fixed by #504
Closed

Change scrollX & scrollY to pageXOffset & pageYOffset? #480

johanalkstal opened this issue Oct 18, 2018 · 1 comment · Fixed by #504

Comments

@johanalkstal
Copy link

Should these values be changed for the same reasons they were changed in Svelte?

sapper/templates/src/client/app.ts

Lines 104 to 105 in d3e5603

x: scrollX,
y: scrollY

Old Svelte issue, sveltejs/svelte#1175
@johanalkstal johanalkstal changed the title Change scrollX & scrollY to pageOffsetX & pageOffsetY? Change scrollX & scrollY to pageXOffset & pageYOffset? Oct 18, 2018
Rich-Harris added a commit that referenced this issue Oct 27, 2018
@Rich-Harris
change scroll[X|Y] to page[X|Y]Offset - closes #480
4f72044
@Rich-Harris Rich-Harris mentioned this issue Oct 27, 2018
Merged
Rich-Harris added a commit that referenced this issue Oct 27, 2018
@Rich-Harris
Merge pull request #504 from sveltejs/gh-480
198be28 
change scroll[X|Y] to page[X|Y]Offset
@Rich-Harris
Copy link
Member

Good idea, thanks — fixed in 0.24

@jacobmischka jacobmischka mentioned this issue Nov 5, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change scroll[X|Y] to page[X|Y]Offset sveltejs/sapper
2 participants
@Rich-Harris @johanalkstal