Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken chrome version. #78

Closed

Conversation

iandoesallthethings
Copy link

Got this working in chrome and Arc thanks to @wheezard in #63

@bershanskiy
Copy link
Contributor

@iandoesallthethings Hi, did you include package-lock.json on purpose or accidentally? Since the it was not part of the repo, it's possible that the original author did not include it intentionally.

@iandoesallthethings
Copy link
Author

Ah, that was unintentional. Fixed it.

@bershanskiy
Copy link
Contributor

@iandoesallthethings I just tested on Firefox and this PR breaks extension on Firefox since Firefox resolves paths relative to the extension page. A proper fix would be to wrap that line in #if/#else/#endif and process the whole file with rollup-plugin-jscc like other files in the project.

@bershanskiy
Copy link
Contributor

Also, #70 fixes the same bug but a bit differently.

@bershanskiy bershanskiy mentioned this pull request Sep 13, 2022
@bershanskiy
Copy link
Contributor

@bershanskiy
Copy link
Contributor

The Chromium DevTools bug (linked above) was fixed and fix was already rolled into Chromium. I tested on Chromium Version 108.0.5358.0 (Developer Build) (64-bit) and sender.url was fine. Most likely, Chromium Canary was already fixed too. We can expect Chromium 108 to release with Svelte DevTools working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants