Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocess options should be on options.preprocess #41

Closed
Rich-Harris opened this issue Jan 20, 2018 · 0 comments · Fixed by #51

Comments

@Rich-Harris
Copy link
Member

commented Jan 20, 2018

I just realised that preprocess functions are being drawn directly from options:

options: {
  style: (...) => {...}
}

For consistency with other integrations, that should be like this instead:

options: {
  preprocess: {
    style: (...) => {...}
  }
}

We'll have to intercept options.style, options.script and options.markup and a) turn them into options.preprocess and b) print a big deprecation warning.

Rich-Harris added a commit that referenced this issue Apr 6, 2018
Rich-Harris added a commit that referenced this issue Apr 6, 2018
deprecate options.style etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.