From bf7e47638d0faba3fb913e65108e3bb44e7ab233 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Mon, 7 Apr 2025 11:49:11 -0400 Subject: [PATCH 1/3] squelch some warnings --- apps/svelte.dev/src/lib/db/client.js | 6 ++---- .../src/routes/tutorial/[...slug]/ImageViewer.svelte | 3 +-- packages/site-kit/src/lib/markdown/renderer.ts | 2 +- packages/site-kit/src/lib/markdown/utils.ts | 2 +- 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/apps/svelte.dev/src/lib/db/client.js b/apps/svelte.dev/src/lib/db/client.js index 634e1342d1..0f3dd5a40a 100644 --- a/apps/svelte.dev/src/lib/db/client.js +++ b/apps/svelte.dev/src/lib/db/client.js @@ -2,9 +2,7 @@ import { building } from '$app/environment'; import { env } from '$env/dynamic/private'; import { createClient } from '@supabase/supabase-js'; -const enabled = !building && env.SUPABASE_URL && env.SUPABASE_KEY; - -if (!enabled) { +if (!building && (!env.SUPABASE_URL || !env.SUPABASE_KEY)) { console.warn( `Missing SUPABASE_URL and SUPABASE_KEY environment variables. Loading and saving in the playground is disabled` ); @@ -15,7 +13,7 @@ if (!enabled) { */ // @ts-ignore-line export const client = - enabled && + !building && createClient(env.SUPABASE_URL, env.SUPABASE_KEY, { global: { fetch }, auth: { persistSession: false } diff --git a/apps/svelte.dev/src/routes/tutorial/[...slug]/ImageViewer.svelte b/apps/svelte.dev/src/routes/tutorial/[...slug]/ImageViewer.svelte index 65c65c8a3f..433f48400f 100644 --- a/apps/svelte.dev/src/routes/tutorial/[...slug]/ImageViewer.svelte +++ b/apps/svelte.dev/src/routes/tutorial/[...slug]/ImageViewer.svelte @@ -32,8 +32,7 @@ display: flex; align-items: center; justify-content: center; - background: white - url('data:image/svg+xml;utf8,'); + background: white url('./image-viewer-background.svg'); } img { diff --git a/packages/site-kit/src/lib/markdown/renderer.ts b/packages/site-kit/src/lib/markdown/renderer.ts index d39b68545e..c453ed2b6c 100644 --- a/packages/site-kit/src/lib/markdown/renderer.ts +++ b/packages/site-kit/src/lib/markdown/renderer.ts @@ -1,5 +1,5 @@ import MagicString from 'magic-string'; -import { createHash, Hash } from 'node:crypto'; +import { createHash, type Hash } from 'node:crypto'; import fs from 'node:fs'; import process from 'node:process'; import path from 'node:path'; diff --git a/packages/site-kit/src/lib/markdown/utils.ts b/packages/site-kit/src/lib/markdown/utils.ts index 71bafd9f90..559d507456 100644 --- a/packages/site-kit/src/lib/markdown/utils.ts +++ b/packages/site-kit/src/lib/markdown/utils.ts @@ -1,4 +1,4 @@ -import { Marked, Renderer, type TokenizerObject, type MarkedExtension } from 'marked'; +import { Marked, type Renderer, type TokenizerObject, type MarkedExtension } from 'marked'; import json5 from 'json5'; export const SHIKI_LANGUAGE_MAP = { From 5c2f135b396ec0bba41750cae70277012f96ccde Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Mon, 7 Apr 2025 12:01:00 -0400 Subject: [PATCH 2/3] maybe this? --- .../svelte.dev/src/routes/tutorial/[...slug]/ImageViewer.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/svelte.dev/src/routes/tutorial/[...slug]/ImageViewer.svelte b/apps/svelte.dev/src/routes/tutorial/[...slug]/ImageViewer.svelte index 433f48400f..d426a3c025 100644 --- a/apps/svelte.dev/src/routes/tutorial/[...slug]/ImageViewer.svelte +++ b/apps/svelte.dev/src/routes/tutorial/[...slug]/ImageViewer.svelte @@ -32,7 +32,7 @@ display: flex; align-items: center; justify-content: center; - background: white url('./image-viewer-background.svg'); + background: white url(./image-viewer-background.svg); } img { From 7684e17eb393193b279aeee9c9a3c24a9dd91b07 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Mon, 7 Apr 2025 12:04:12 -0400 Subject: [PATCH 3/3] oops, errant git clean --- .../src/routes/tutorial/[...slug]/image-viewer-background.svg | 1 + 1 file changed, 1 insertion(+) create mode 100644 apps/svelte.dev/src/routes/tutorial/[...slug]/image-viewer-background.svg diff --git a/apps/svelte.dev/src/routes/tutorial/[...slug]/image-viewer-background.svg b/apps/svelte.dev/src/routes/tutorial/[...slug]/image-viewer-background.svg new file mode 100644 index 0000000000..b01de8f26f --- /dev/null +++ b/apps/svelte.dev/src/routes/tutorial/[...slug]/image-viewer-background.svg @@ -0,0 +1 @@ +