Skip to content

fix: better CommonJS transformation #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
+6 −5
Merged

fix: better CommonJS transformation #1660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/repl/src/lib/workers/bundler/plugins/commonjs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const plugin: Plugin = {
});

const requires: string[] = [];
const exports: string[] = [];
const exports: Set<string> = new Set();

walk(ast as Node, null, {
CallExpression: (node, context) => {
Expand All @@ -52,9 +52,7 @@ const plugin: Plugin = {

// Default is a special case (and would result in invalid syntax) and kinda fucked up: https://github.com/evanw/esbuild/issues/1719#issuecomment-953470495
if (node.left.property.name !== 'default') {
exports.push(
`export const ${node.left.property.name} = module.exports.${node.left.property.name};`
);
exports.add(node.left.property.name);
}
}
});
Expand All @@ -76,7 +74,10 @@ const plugin: Plugin = {
`const exports = {}; const module = { exports };`,
code,
`export default module.exports;`,
exports.join('\n')
...Array.from(exports).map((name) => {
const alias = `$$module_exports_${name}`;
return `const ${alias} = module.exports.${name}; export { ${alias} as ${name} };`;
})
].join('\n\n');

return {
Expand Down