From 85557b172a7c6ce7b9765febda27e1f1aa09320f Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Thu, 3 Oct 2024 11:58:25 -0400 Subject: [PATCH 1/6] simplify --- apps/svelte.dev/src/routes/+error.svelte | 2 +- .../svelte.dev/src/routes/_home/Svelte.svelte | 2 +- apps/svelte.dev/src/routes/_home/common.css | 9 -------- .../svelte.dev/src/routes/search/+page.svelte | 3 +-- .../src/routes/tutorial/[slug]/Loading.svelte | 3 ++- .../site-kit/src/lib/components/Text.svelte | 18 +--------------- packages/site-kit/src/lib/home/Blurb.svelte | 9 -------- .../site-kit/src/lib/home/TrySection.svelte | 1 - packages/site-kit/src/lib/nav/Menu.svelte | 9 -------- .../src/lib/nav/NavContextMenu.svelte | 19 ++++++++--------- packages/site-kit/src/lib/styles/base.css | 21 +++++++------------ packages/site-kit/src/lib/styles/tokens.css | 12 +++++------ 12 files changed, 28 insertions(+), 80 deletions(-) diff --git a/apps/svelte.dev/src/routes/+error.svelte b/apps/svelte.dev/src/routes/+error.svelte index f998884a3c..bb7939b096 100644 --- a/apps/svelte.dev/src/routes/+error.svelte +++ b/apps/svelte.dev/src/routes/+error.svelte @@ -62,7 +62,7 @@ } h1 { - font-size: var(--sk-text-xxl); + font-size: var(--sk-font-size-h1); margin: 0 0 0.5em 0; } diff --git a/apps/svelte.dev/src/routes/_home/Svelte.svelte b/apps/svelte.dev/src/routes/_home/Svelte.svelte index 709631ea1c..e88b5451c4 100644 --- a/apps/svelte.dev/src/routes/_home/Svelte.svelte +++ b/apps/svelte.dev/src/routes/_home/Svelte.svelte @@ -78,7 +78,7 @@ .definition em { font-style: normal; - font-size: var(--sk-text-xxl); + font-size: var(--sk-font-size-h1); color: var(--sk-theme-1); } diff --git a/apps/svelte.dev/src/routes/_home/common.css b/apps/svelte.dev/src/routes/_home/common.css index 80d47c279d..ae7cc517a2 100644 --- a/apps/svelte.dev/src/routes/_home/common.css +++ b/apps/svelte.dev/src/routes/_home/common.css @@ -7,11 +7,6 @@ --background-2: var(--sk-theme-2); } -.home h2 { - font-size: var(--sk-text-xl); - line-height: 1.2; -} - .home .grid { display: grid; gap: 1em; @@ -23,10 +18,6 @@ } @media (min-width: 900px) { - .home h2 { - font-size: var(--sk-text-xxl); - } - .home .grid { grid-template-columns: repeat(var(--columns), 1fr); gap: 7rem; diff --git a/apps/svelte.dev/src/routes/search/+page.svelte b/apps/svelte.dev/src/routes/search/+page.svelte index 4498f9b1db..98be90b02a 100644 --- a/apps/svelte.dev/src/routes/search/+page.svelte +++ b/apps/svelte.dev/src/routes/search/+page.svelte @@ -44,9 +44,8 @@ width: 100%; height: 100%; font-family: inherit; - font-size: var(--sk-text-xl); + font-size: var(--sk-font-size-h2); border: none; - /* border: 1px solid var(--sk-back-5); */ border-radius: var(--sk-border-radius); padding: 2rem 2rem 2rem 5rem; background: no-repeat 1rem 50% / 3rem 3rem url(/icons/search.svg); diff --git a/apps/svelte.dev/src/routes/tutorial/[slug]/Loading.svelte b/apps/svelte.dev/src/routes/tutorial/[slug]/Loading.svelte index aa33b1ba60..7f92aa599d 100644 --- a/apps/svelte.dev/src/routes/tutorial/[slug]/Loading.svelte +++ b/apps/svelte.dev/src/routes/tutorial/[slug]/Loading.svelte @@ -160,7 +160,8 @@ } h2 { - font-size: var(--sk-text-xl); + font-family: var(--sk-font-ui); + font-size: var(--sk-font-size-ui-large); } p { diff --git a/packages/site-kit/src/lib/components/Text.svelte b/packages/site-kit/src/lib/components/Text.svelte index 7107d235da..22fc236596 100644 --- a/packages/site-kit/src/lib/components/Text.svelte +++ b/packages/site-kit/src/lib/components/Text.svelte @@ -68,22 +68,6 @@ font-size: var(--sk-text-m); } - /* TODO is this still used? don't think so */ - section { - max-width: var(--sk-line-max-width); - padding: 0 0 0 1rem; - - h2, - h3, - h4 { - margin-left: -1rem; - } - - a code { - color: inherit; - } - } - code { white-space: pre-wrap; padding: 0.2rem 0.4rem; @@ -324,7 +308,7 @@ opacity: 0; transition: opacity 0.2s; - :where(h2, h3, h4, h5, h6):hover & { + :where(h2, h3):hover & { opacity: 1; } } diff --git a/packages/site-kit/src/lib/home/Blurb.svelte b/packages/site-kit/src/lib/home/Blurb.svelte index 540defa308..21096d3c21 100644 --- a/packages/site-kit/src/lib/home/Blurb.svelte +++ b/packages/site-kit/src/lib/home/Blurb.svelte @@ -36,11 +36,6 @@ grid-gap: 1rem; } - .grid :global(h2) { - font-size: var(--sk-text-xl); - line-height: 1.2; - } - .grid { display: grid; gap: 1em; @@ -52,10 +47,6 @@ } @media (min-width: 900px) { - .grid :global(h2) { - font-size: var(--sk-text-xl); - } - .grid { --columns: 3; diff --git a/packages/site-kit/src/lib/home/TrySection.svelte b/packages/site-kit/src/lib/home/TrySection.svelte index 2589265659..3f50f8040b 100644 --- a/packages/site-kit/src/lib/home/TrySection.svelte +++ b/packages/site-kit/src/lib/home/TrySection.svelte @@ -74,7 +74,6 @@ display: inline-block; width: 25rem; margin: 0 0 1rem; - font-size: var(--sk-text-xl); } @media (min-width: 900px) { diff --git a/packages/site-kit/src/lib/nav/Menu.svelte b/packages/site-kit/src/lib/nav/Menu.svelte index 466590f1fc..f0a7f51686 100644 --- a/packages/site-kit/src/lib/nav/Menu.svelte +++ b/packages/site-kit/src/lib/nav/Menu.svelte @@ -430,10 +430,6 @@ padding-left: 1rem; } - .viewport :global(a[aria-current='true']) { - background-color: hsla(var(--sk-theme-1-hsl), 0.05); - } - .viewport :global(a:hover), .related-menu-arrow:hover { border-radius: var(--sk-border-radius); @@ -442,9 +438,4 @@ background-color: var(--sk-back-4); } - - .viewport :global(a[aria-current='true']:hover) { - background-color: hsla(var(--sk-theme-1-hsl), 0.05); - color: var(--sk-theme-1); - } diff --git a/packages/site-kit/src/lib/nav/NavContextMenu.svelte b/packages/site-kit/src/lib/nav/NavContextMenu.svelte index 5ad348201d..1b8e6fa92c 100644 --- a/packages/site-kit/src/lib/nav/NavContextMenu.svelte +++ b/packages/site-kit/src/lib/nav/NavContextMenu.svelte @@ -34,16 +34,16 @@ {#if contents} {#each contents as { sections, title }, index}
-

{title}

+

{title}

{#if sections.length !== 0}
diff --git a/apps/svelte.dev/src/routes/docs/[...path]/+page.svelte b/apps/svelte.dev/src/routes/docs/[...path]/+page.svelte index fc7e16f4f1..f36464b577 100644 --- a/apps/svelte.dev/src/routes/docs/[...path]/+page.svelte +++ b/apps/svelte.dev/src/routes/docs/[...path]/+page.svelte @@ -108,7 +108,7 @@ .controls span { display: block; - font-size: var(--sk-text-s); + font-size: var(--sk-font-size-ui); text-transform: uppercase; font-weight: 400; font-family: var(--sk-font-ui); diff --git a/apps/svelte.dev/src/routes/docs/[...path]/Breadcrumbs.svelte b/apps/svelte.dev/src/routes/docs/[...path]/Breadcrumbs.svelte index e653287548..babf7edeb7 100644 --- a/apps/svelte.dev/src/routes/docs/[...path]/Breadcrumbs.svelte +++ b/apps/svelte.dev/src/routes/docs/[...path]/Breadcrumbs.svelte @@ -11,7 +11,7 @@ diff --git a/packages/site-kit/src/lib/components/Shell.svelte b/packages/site-kit/src/lib/components/Shell.svelte index db4c1c148c..6f553c472b 100644 --- a/packages/site-kit/src/lib/components/Shell.svelte +++ b/packages/site-kit/src/lib/components/Shell.svelte @@ -83,8 +83,4 @@ The main shell of the application. It provides a slot for the top navigation, th padding-bottom: 0; } } - - :global(body) { - font-size: var(--sk-text-s) !important; - } diff --git a/packages/site-kit/src/lib/components/Text.svelte b/packages/site-kit/src/lib/components/Text.svelte index e4a642f995..ad3e95f16f 100644 --- a/packages/site-kit/src/lib/components/Text.svelte +++ b/packages/site-kit/src/lib/components/Text.svelte @@ -234,7 +234,6 @@ box-sizing: border-box; color: var(--sk-code-base); border-radius: var(--sk-border-radius); - font-size: var(--sk-text-s); overflow-x: auto; code { @@ -354,7 +353,7 @@ } small { - font-size: var(--sk-text-s); + font-size: var(--sk-font-size-body-small); float: right; pointer-events: all; color: var(--sk-theme-1); diff --git a/packages/site-kit/src/lib/docs/DocsContents.svelte b/packages/site-kit/src/lib/docs/DocsContents.svelte index d7b4a0a57b..caf177bb17 100644 --- a/packages/site-kit/src/lib/docs/DocsContents.svelte +++ b/packages/site-kit/src/lib/docs/DocsContents.svelte @@ -101,7 +101,7 @@ .page { display: block; - font-size: var(--sk-text-s); + font-size: var(--sk-font-size-body-small); font-family: var(--sk-font-body); } diff --git a/packages/site-kit/src/lib/home/Footer.svelte b/packages/site-kit/src/lib/home/Footer.svelte index f1bd923d65..fe96d5df45 100644 --- a/packages/site-kit/src/lib/home/Footer.svelte +++ b/packages/site-kit/src/lib/home/Footer.svelte @@ -66,7 +66,7 @@ .links a { color: var(--sk-text-2); - font-size: var(--sk-text-s); + font-size: var(--sk-font-size-body-small); display: block; line-height: 1.8; } diff --git a/packages/site-kit/src/lib/nav/Menu.svelte b/packages/site-kit/src/lib/nav/Menu.svelte index f0a7f51686..c310ea3425 100644 --- a/packages/site-kit/src/lib/nav/Menu.svelte +++ b/packages/site-kit/src/lib/nav/Menu.svelte @@ -367,7 +367,7 @@ justify-content: start; gap: 1rem; - font-size: 0.9em; + font-size: var(--sk-font-size-ui-small); color: var(--sk-text-3); background-color: var(--sk-back-3); diff --git a/packages/site-kit/src/lib/nav/Nav.svelte b/packages/site-kit/src/lib/nav/Nav.svelte index 0c57109d6c..0787391c1c 100644 --- a/packages/site-kit/src/lib/nav/Nav.svelte +++ b/packages/site-kit/src/lib/nav/Nav.svelte @@ -253,7 +253,6 @@ Top navigation bar for the application. It provides a slot for the left side, th .appearance .caption { display: none; - font-size: var(--sk-text-xs); line-height: 1; margin-right: 0rem; } @@ -276,13 +275,12 @@ Top navigation bar for the application. It provides a slot for the left side, th position: relative; display: flex; padding: 1.5rem 0; + margin: 0 1rem; justify-content: space-between; } .appearance .caption { display: block; - - font-size: var(--sk-text-s); } nav :global(.large) { diff --git a/packages/site-kit/src/lib/nav/NavContextMenu.svelte b/packages/site-kit/src/lib/nav/NavContextMenu.svelte index 1b8e6fa92c..28a94703f5 100644 --- a/packages/site-kit/src/lib/nav/NavContextMenu.svelte +++ b/packages/site-kit/src/lib/nav/NavContextMenu.svelte @@ -47,15 +47,10 @@ {/if}