From e2a1a71d5fc4a991171f930b4acdef074f55c627 Mon Sep 17 00:00:00 2001 From: heygwangjin Date: Sat, 26 Oct 2024 04:17:28 +0900 Subject: [PATCH 1/3] change color of bullet point (#542) --- packages/site-kit/src/lib/components/Text.svelte | 2 +- packages/site-kit/src/lib/styles/tokens.css | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/site-kit/src/lib/components/Text.svelte b/packages/site-kit/src/lib/components/Text.svelte index 7a8a77700c..e14f7f8d2e 100644 --- a/packages/site-kit/src/lib/components/Text.svelte +++ b/packages/site-kit/src/lib/components/Text.svelte @@ -378,7 +378,7 @@ position: absolute; top: calc(50% - 0.3rem); left: -1.8rem; - background-color: var(--sk-back-5); + background-color: var(--sk-back-7); width: 0.6rem; height: 0.6rem; border-radius: 50%; diff --git a/packages/site-kit/src/lib/styles/tokens.css b/packages/site-kit/src/lib/styles/tokens.css index 206de0470b..ed4d77cca8 100644 --- a/packages/site-kit/src/lib/styles/tokens.css +++ b/packages/site-kit/src/lib/styles/tokens.css @@ -64,6 +64,7 @@ --sk-back-4: hsl(0, 0%, 95%); --sk-back-5: hsl(0, 0%, 92%); --sk-back-6: hsl(0, 0%, 86%); + --sk-back-7: hsl(0, 0%, 72%); --sk-text-1: hsl(0, 0%, 5%); --sk-text-2: hsl(0, 0%, 12%); @@ -140,6 +141,7 @@ --sk-back-4: hsl(var(--sk-back-hue), 15%, 22%); --sk-back-5: hsl(var(--sk-back-hue), 15%, 25%); --sk-back-6: hsl(var(--sk-back-hue), 15%, 32%); + --sk-back-7: hsl(var(--sk-back-hue), 15%, 36%); --sk-back-translucent: hsla(0, 0%, 100%, 0.1); --sk-theme-1-hsl: 12, 94%, 62%; --sk-text-1: hsl(var(--sk-back-hue), 10%, 90%); From 922dc520775f6d60de00ee9302d6517d3a7a709d Mon Sep 17 00:00:00 2001 From: heygwangjin Date: Sat, 26 Oct 2024 04:18:18 +0900 Subject: [PATCH 2/3] change position of bullet point (#542) --- packages/site-kit/src/lib/components/Text.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/site-kit/src/lib/components/Text.svelte b/packages/site-kit/src/lib/components/Text.svelte index e14f7f8d2e..19abe39c51 100644 --- a/packages/site-kit/src/lib/components/Text.svelte +++ b/packages/site-kit/src/lib/components/Text.svelte @@ -376,7 +376,7 @@ li::before { content: ''; position: absolute; - top: calc(50% - 0.3rem); + top: 1.43rem; left: -1.8rem; background-color: var(--sk-back-7); width: 0.6rem; From 999269ec5ccaf76d8254b22c9ab8722e584448c5 Mon Sep 17 00:00:00 2001 From: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Mon, 28 Oct 2024 11:38:03 +0100 Subject: [PATCH 3/3] Apply suggestions from code review --- packages/site-kit/src/lib/components/Text.svelte | 2 +- packages/site-kit/src/lib/styles/tokens.css | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/site-kit/src/lib/components/Text.svelte b/packages/site-kit/src/lib/components/Text.svelte index 19abe39c51..aac3eae31b 100644 --- a/packages/site-kit/src/lib/components/Text.svelte +++ b/packages/site-kit/src/lib/components/Text.svelte @@ -378,7 +378,7 @@ position: absolute; top: 1.43rem; left: -1.8rem; - background-color: var(--sk-back-7); + background-color: var(--sk-text-4); width: 0.6rem; height: 0.6rem; border-radius: 50%; diff --git a/packages/site-kit/src/lib/styles/tokens.css b/packages/site-kit/src/lib/styles/tokens.css index ed4d77cca8..206de0470b 100644 --- a/packages/site-kit/src/lib/styles/tokens.css +++ b/packages/site-kit/src/lib/styles/tokens.css @@ -64,7 +64,6 @@ --sk-back-4: hsl(0, 0%, 95%); --sk-back-5: hsl(0, 0%, 92%); --sk-back-6: hsl(0, 0%, 86%); - --sk-back-7: hsl(0, 0%, 72%); --sk-text-1: hsl(0, 0%, 5%); --sk-text-2: hsl(0, 0%, 12%); @@ -141,7 +140,6 @@ --sk-back-4: hsl(var(--sk-back-hue), 15%, 22%); --sk-back-5: hsl(var(--sk-back-hue), 15%, 25%); --sk-back-6: hsl(var(--sk-back-hue), 15%, 32%); - --sk-back-7: hsl(var(--sk-back-hue), 15%, 36%); --sk-back-translucent: hsla(0, 0%, 100%, 0.1); --sk-theme-1-hsl: 12, 94%, 62%; --sk-text-1: hsl(var(--sk-back-hue), 10%, 90%);