Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.25.1 breaks store direct property assignment #5412

Closed
trmcnvn opened this issue Sep 17, 2020 · 1 comment
Closed

v3.25.1 breaks store direct property assignment #5412

trmcnvn opened this issue Sep 17, 2020 · 1 comment

Comments

@trmcnvn
Copy link

@trmcnvn trmcnvn commented Sep 17, 2020

PR #5390 introduced a bug where upon direct property assignment on a store it will overwrite the entire store's value.

Reproduction
https://svelte.dev/repl/d9156516adcd4775b89112b65a071ef4?version=3.25.1

3.25.0 Compiler Output

set_store_value(store, $store.data = [1, 2, 3, 4], $store);

3.25.1 Compiler Ouput

set_store_value(store, $store.data = [1, 2, 3, 4]);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.