Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint warning: 'variable' is not defined #5463

Closed
JestDotty opened this issue Aug 15, 2020 · 2 comments · Fixed by #5468
Closed

Lint warning: 'variable' is not defined #5463

JestDotty opened this issue Aug 15, 2020 · 2 comments · Fixed by #5468

Comments

@JestDotty
Copy link

image

EventSource is a browser API for Server-Side-Events (one way socket connections): https://developer.mozilla.org/en-US/docs/Web/API/EventSource

does svelte-loader have a way to declare global variables, or is there some kind of file that needs a PR?
@Conduitry Conduitry transferred this issue from sveltejs/svelte-loader Sep 28, 2020
@Conduitry
Copy link
Member

Transferring this to the svelte repo. The proposal here is presumably to add EventSource as a known global in src/compiler/utils/names.ts.

@tanhauhau tanhauhau mentioned this issue Sep 29, 2020
Merged
4 tasks
@Conduitry
Copy link
Member

EventSource is now recognized as a known global and doesn't trigger the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add EventSource to the known globals tanhauhau/svelte
2 participants
@JestDotty @Conduitry