Skip to content

Conversation

@benmccann
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2023

⚠️ No Changeset found

Latest commit: 7244533

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2023 6:33pm

@dummdidumm
Copy link
Member

The code example is a bit confusing to read - can we only mention it in the text but keep the example as simple as before?

@benmccann
Copy link
Member Author

I wouldn't be opposed to that. I wonder if we should try to find a better example though? The thing that's funny to me about the current example is that the majority of the time people are going to be using proxied state it will be with an object rather than an array, so it felt to me like we should show an object in the example. Was there anything you felt to be particularly awkward about the changes I made to the example or any ideas on improving it?

@benmccann benmccann added this to the 5.0 milestone Jan 6, 2024
@Rich-Harris
Copy link
Member

Is this something people are struggling with? I think we could just add the word 'deeply' and be done with it. In due course there'll be proper tutorials for all this stuff

@Rich-Harris
Copy link
Member

closing in favour of #10354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants