Skip to content

Conversation

@realguse
Copy link
Contributor

This PR changes the style of the badges to better match the "square" look of the banner.

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2024

⚠️ No Changeset found

Latest commit: 92027cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann
Copy link
Member

I think the style change is fine, but it also makes them much larger: https://github.com/realguse/svelte/tree/patch-1

Can we change the style without changing the size quite so much?

@realguse
Copy link
Contributor Author

realguse commented Oct 28, 2024

@benmccann, this would be possible, but I think it would require switching the readme to html, instead of markdown. If you look at catppuccins readme, they're doing the same that I'm going for with the labels

So, what do you think, is it worth switching it to html. Or we could just have the badges section in html, and the rest in markdown, but that would add some confusion.

@Ocean-OS
Copy link
Member

@benmccann, this would be possible, but I think it would require switching the readme to html, instead of markdown. If you look at catppuccins readme, they're doing the same that I'm going for with the labels

So, what do you think, is it worth switching it to html. Or we could just have the badges section in html, and the rest in markdown, but that would add some confusion.

You can use both HTML and MD in the same file, it shouldn't matter/make any difference

@realguse
Copy link
Contributor Author

realguse commented Oct 29, 2024

@benmccann The only thing I'm thinking if regarding to that, would be the inconsistency, but if that's not a problem I'll see what I can do. I'm also thinking of adding more badges, like stars etc. What do you think of that?

@realguse
Copy link
Contributor Author

@benmccann, I have converted only the badges to html and have made them smaller, hope this is good. (sry for the messy log)

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 29, 2024

pnpm add https://pkg.pr.new/svelte@13980

commit: 92027cf

@benmccann
Copy link
Member

I just messed around with the styles and personally I prefer the current styling. I feel this flat styling makes it unclear that the elements are clickable

This PR changes the style of the badges to better match the "square" look of the banner.

The banner doesn't appear square to me, but appears transparent. Maybe this is different in dark mode. I'm not sure. But if so, that might be the better thing to address

@realguse
Copy link
Contributor Author

realguse commented Oct 29, 2024

I dont think many people will click on them anyways, maybe the discord but. And with the square look i mean that the badges look similar in both form and sharpness to the banner. And the banner doesn't look very clickable either, even though it is.

@realguse realguse closed this Nov 9, 2024
@realguse realguse deleted the patch-1 branch November 9, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants