-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
docs: improve badges #13980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve badges #13980
Conversation
|
|
I think the style change is fine, but it also makes them much larger: https://github.com/realguse/svelte/tree/patch-1 Can we change the style without changing the size quite so much? |
|
@benmccann, this would be possible, but I think it would require switching the readme to html, instead of markdown. If you look at catppuccins readme, they're doing the same that I'm going for with the labels So, what do you think, is it worth switching it to html. Or we could just have the badges section in html, and the rest in markdown, but that would add some confusion. |
You can use both HTML and MD in the same file, it shouldn't matter/make any difference |
|
@benmccann The only thing I'm thinking if regarding to that, would be the inconsistency, but if that's not a problem I'll see what I can do. I'm also thinking of adding more badges, like stars etc. What do you think of that? |
|
@benmccann, I have converted only the badges to html and have made them smaller, hope this is good. (sry for the messy log) |
commit: |
|
I just messed around with the styles and personally I prefer the current styling. I feel this flat styling makes it unclear that the elements are clickable
The banner doesn't appear square to me, but appears transparent. Maybe this is different in dark mode. I'm not sure. But if so, that might be the better thing to address |
|
I dont think many people will click on them anyways, maybe the discord but. And with the square look i mean that the badges look similar in both form and sharpness to the banner. And the banner doesn't look very clickable either, even though it is. |
This PR changes the style of the badges to better match the "square" look of the banner.