fix: match class and style directives against attribute selector#16179
fix: match class and style directives against attribute selector#16179Rich-Harris merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: cf26945 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Whatever you did in this change, all my buttons just turned white |
|
These directives add |
|
I mean just doing this it doesnt show a red background when i add a class="base" even with nothing in it but if I remove class="base" then the red shows. I dont specify background-color at all in .base and i want the conditional class to be prioritized when it its true |
|
This is breaking sites where class props are defined as undefined |
|
@mattpilott I don't really get what gets broken in your example. Can you test on #16204? |
|
That PR fixes this repro. |
Closes #16162
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint