fix: untrack $inspect.with and add check for unsafe mutation#16209
Merged
paoloricciuti merged 2 commits intomainfrom Jun 23, 2025
Merged
fix: untrack $inspect.with and add check for unsafe mutation#16209paoloricciuti merged 2 commits intomainfrom
$inspect.with and add check for unsafe mutation#16209paoloricciuti merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: d4f7fad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Rich-Harris
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16156
It's important for inspect to be pure both because it's not there in production and because being sync it can tear the graph. While writing the test i've also noticed that if you did this
bwas also a dependency of the whole inspect (and it was not even showing up in the logs) so i untracked theinspectorcall (keeping the snapshot outside of theuntrackto deeply read the value)Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint