Merged
Conversation
🦋 Changeset detectedLatest commit: 97092d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Member
|
Since this changes a bite more we should add a change set |
dummdidumm
approved these changes
Jul 10, 2025
dummdidumm
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
couple of changes here:
$effect. whenpopruns, the current active effect/reaction are the same as they were when the effect was declared, so theset_active_effectandset_active_reactioncalls are no-ops. By extension, we don't need to stash the current active effect/reaction, and we don't need to wrap the effect creation in a try-catchcomponent_context.ecan just be an array of functions rather than an array of objects — less memory usage for components with effects$effectbecause the currentactive_effectis aBRANCH_EFFECT, and the currentactive_reactionisnull. These conditions do not obtain in any other circumstances. Consequently, we can remove themflag — it's unnecessary. This saves more memory