fix: silence $inspect errors when the effect is about to be destroyed#16391
Merged
Rich-Harris merged 2 commits intomainfrom Jul 16, 2025
Merged
fix: silence $inspect errors when the effect is about to be destroyed#16391Rich-Harris merged 2 commits intomainfrom
$inspect errors when the effect is about to be destroyed#16391Rich-Harris merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 8d6875f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
Contributor
|
elliott-with-the-longest-name-on-github
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16386 got me thinking — what if instead of making these errors less scary we just didn't show them?
In this PR, if an error occurs while reading
$inspect(value), we don't print it immediately. Instead, we stash it. Then, in a sibling render effect, we read the value again (so that the two effects have the same dependencies) and log the error if it occurred.In 99% of cases (the cases like #16280 (comment)) the render effect will be destroyed before this happens. In the remaining 1%, the error is still logged, with the same stack trace, just a nanosecond later.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint