fix: don't update a focused input with values from its own past#16491
Merged
dummdidumm merged 3 commits intomainfrom Jul 24, 2025
Merged
fix: don't update a focused input with values from its own past#16491dummdidumm merged 3 commits intomainfrom
dummdidumm merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: d5f0b6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
dummdidumm
reviewed
Jul 24, 2025
Member
Author
|
working on that no-async test failure |
dummdidumm
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes another lil' regression from #16482 — because we unset
current_batchbefore flushing effects, the 'this input is being updated because of a state change that we started' logic is broken. A simple fix is to track the previous batch, and unset it at an appropriate timeBefore submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint