Conversation
🦋 Changeset detectedLatest commit: 59ac067 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| ) && | ||
| node.arguments.some((arg) => arg.type !== 'Literal') // TODO more cases? | ||
| node.arguments.some( | ||
| (arg) => arg.type === 'SpreadElement' || context.state.scope.evaluate(arg).values.has(UNKNOWN) |
There was a problem hiding this comment.
Evaluation of SpreadElement will result in UNKNOWN anyway, so the first check can be removed, right?
And maybe it's cleaner to add has/is_unknown prop-flag to Evaluation and use it here.
There was a problem hiding this comment.
Scope.evaluate's parameters only accept an Expression node, which does not include SpreadElements.
I'll add the has unknown check in a bit.
|
I actually don't think we can rename |
|
If you were to |
This removes some
// TODOcomments. It shouldn't change much behavior-wise, as it's mostly tweaks to types.Since this does change an AST node's
type, I will update #16188 once this is merged.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint