fix: ensure async deriveds always get dependencies from thennable#16672
Merged
Rich-Harris merged 1 commit intomainfrom Aug 25, 2025
Merged
fix: ensure async deriveds always get dependencies from thennable#16672Rich-Harris merged 1 commit intomainfrom
Rich-Harris merged 1 commit intomainfrom
Conversation
When an async derived already has a previous promise that is still pending, we were not accessing the `then` property of the new promise. If that property access causes signals to be read, that meant that those dependencies were lost and as such the derived wouldn't rerun anymore when it should. The fix is to make sure to always access the thennable.
🦋 Changeset detectedLatest commit: 5d3db10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Rich-Harris
approved these changes
Aug 25, 2025
Contributor
|
Something in svelte@5.38.5 broke top-level await for me. Data loaded with top-level await silently fails to load. 5.38.3 is the last version in which this still works. |
Contributor
|
@DePasqualeOrg I'd say open a new issue tagging this PR with a minimum reproduction this might go unnoticed since it's on a merged PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an async derived already has a previous promise that is still pending, we were not accessing the
thenproperty of the new promise. If that property access causes signals to be read, that meant that those dependencies were lost and as such the derived wouldn't rerun anymore when it should. The fix is to make sure to always access the thennable.Discovered this while working on the
query.streamPR (it didn't update in some cases and this is the reason why)Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint