chore: run boundary async effects in the context of the current batch#16968
Merged
Rich-Harris merged 1 commit intomainfrom Oct 17, 2025
Merged
chore: run boundary async effects in the context of the current batch#16968Rich-Harris merged 1 commit intomainfrom
Rich-Harris merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 7c1408d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Member
Author
|
going to self-merge this to make my local diffs slightly less chaotic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to rethink how boundaries and batches work in relation to each other, per #16959 (comment). As a starting point, we can get rid of
#boundary_async_effects, since separating them out achieves nothing — the distinction is whether the async effect should delay the batch from committing, but that's determined inside the async effect itself, not during traversal, so the only impact of having this array is that the effect runs outside the batch context. But that isn't useful (it doesn't save us from re-running it as necessary), it's just an extra array allocation/iteration.This will enable further experimentation since we can now guarantee that
current_batchexists for all suspendy async effects.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint