chore: lift "flushSync cannot be called in effects" restriction

[dummdidumm]

Since async-await was introduced into the code base a lot has changed. This proposes to lift the restriction that flushSync cannot be called in effects. No tests fail, and in general the whole logic is a lot more robust now (and, to be fair, the stack traces when debugging are confusing either way).

Closes #17131 (though I still wonder why Skeleton does that)

Before submitting the PR, please make sure you do the following

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• Prefix your PR title with feat:, fix:, chore:, or docs:.
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.
• If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

• Run the tests with pnpm test and lint the project with pnpm lint

[changeset-bot]

🦋 Changeset detected

Latest commit: 5c32d1b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
svelte	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Playground

pnpm add https://pkg.pr.new/svelte@17139

[Hugos68]

@dummdidumm Skeleton maintainer here, we don't actually call flushSyncor use any Svelte API's, we are build on top of the foundation of ZagJS. This is where they use flushSync: https://github.com/chakra-ui/zag/blob/main/packages/frameworks/svelte/src/bindable.svelte.ts#L43

They build framework agnostic state machines with framework adapters, it's quite complicated but maybe this helps understand the use case or even suggest an improvement.

Edit upon further inspection it looks like it's to flush all current effects before setting the value of a so called "bindable". Which is an internal reactive variable from the looks of it.

@segunadebayo (Creator of Zag) perhaps you could help explain why Zag uses flushSync here? (Or why it's ran inside in $effect for collapsible)

[Torres1080]

I'm using ArkUI which is also powered by ZagJS and I'm facing the same problem. Merging this PR will be much appreciated

[svelte-docs-bot]

Preview: https://svelte-dev-git-preview-svelte-17139-svelte.vercel.app/