From 1f858630d614891092177e06734f1374e7e77a03 Mon Sep 17 00:00:00 2001 From: dylan Date: Wed, 12 Nov 2025 18:09:33 +1300 Subject: [PATCH] fix: each block losing reactivity when items removed while promise pending --- .changeset/clean-toes-joke.md | 5 +++++ .../src/internal/client/dom/blocks/each.js | 1 + .../samples/async-each-derived/_config.js | 20 +++++++++++++++++++ .../samples/async-each-derived/main.svelte | 11 ++++++++++ 4 files changed, 37 insertions(+) create mode 100644 .changeset/clean-toes-joke.md create mode 100644 packages/svelte/tests/runtime-runes/samples/async-each-derived/_config.js create mode 100644 packages/svelte/tests/runtime-runes/samples/async-each-derived/main.svelte diff --git a/.changeset/clean-toes-joke.md b/.changeset/clean-toes-joke.md new file mode 100644 index 000000000000..2c3aa4415f98 --- /dev/null +++ b/.changeset/clean-toes-joke.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: each block losing reactivity when items removed while promise pending diff --git a/packages/svelte/src/internal/client/dom/blocks/each.js b/packages/svelte/src/internal/client/dom/blocks/each.js index a0fae3713305..659e6801f1dc 100644 --- a/packages/svelte/src/internal/client/dom/blocks/each.js +++ b/packages/svelte/src/internal/client/dom/blocks/each.js @@ -283,6 +283,7 @@ export function each(node, flags, get_collection, get_key, render_fn, fallback_f if ((flags & (EACH_ITEM_REACTIVE | EACH_INDEX_REACTIVE)) !== 0) { update_item(existing, value, i, flags); } + batch.skipped_effects.delete(existing.e); } else { item = create_item( null, diff --git a/packages/svelte/tests/runtime-runes/samples/async-each-derived/_config.js b/packages/svelte/tests/runtime-runes/samples/async-each-derived/_config.js new file mode 100644 index 000000000000..62a09bfc7cde --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/async-each-derived/_config.js @@ -0,0 +1,20 @@ +import { tick } from 'svelte'; +import { test } from '../../test'; + +export default test({ + async test({ assert, target }) { + await tick(); // settle initial await + + const checkBox = target.querySelector('input'); + + checkBox?.click(); + await tick(); + assert.htmlEqual( + target.innerHTML, + ` + +

true

+ ` + ); + } +}); diff --git a/packages/svelte/tests/runtime-runes/samples/async-each-derived/main.svelte b/packages/svelte/tests/runtime-runes/samples/async-each-derived/main.svelte new file mode 100644 index 000000000000..7e3b5c54bcc5 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/async-each-derived/main.svelte @@ -0,0 +1,11 @@ + + + + +{#each checked === foo && [1]} +

{checked}

+{/each}