fix: destroy each items after siblings are resumed #17258
Draft
+205
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ones of the bugs identified in #17240 (comment). (To be honest I'm astonished that it lasted this long.) Specifically, when you have an
eachblock go from['a', 'b']to[], and then to['a']while items are still outroing,bwill never be removed from the DOM, because theaoutro is aborted and the callback that destroys effects is never called.This solution is admittedly a bit more involved than I initially hoped. I wonder if it would be better to coordinate effect destruction at the batch level, though I didn't pursue that as it would be a breaking change. At least this change imposes no costs on
eachblocks that don't contain outros.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint