Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dirname of test for select spread #4939

Merged
merged 1 commit into from Jun 1, 2020
Merged

fix: dirname of test for select spread #4939

merged 1 commit into from Jun 1, 2020

Conversation

jthegedus
Copy link
Contributor

Fixes a typo in the dir name of the test. I noticed this after reading @tanhauhau very interesting blog about svelte debugging.

Original PR #4894

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@tanhauhau tanhauhau merged commit 8fc85f0 into sveltejs:master Jun 1, 2020
@tanhauhau
Copy link
Member

thanks!

@jthegedus
Copy link
Contributor Author

No problem, thanks for the sweet blog!

@jthegedus jthegedus deleted the fix-test-dirname branch June 1, 2020 07:54
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants